First pass at support for initial import #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benmccann at first glance it looks good - I will merge it, but I am just not sure how from the test you can garanty this new section of the code is executed? I think the scenario for the test should be:
|
richardwilly98
added a commit
that referenced
this pull request
Sep 26, 2013
First pass at support for initial import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #47
@richardwilly98 hope this is a helpful first pass. since you're more familiar with this code, perhaps you can help me polish it up if there are any additional changes you think are needed. i especially am not sure about how to support gridfs and so i supported only regular collections with this initial implementation